-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passkey keyword to after_passkey_authentication
#26
Add passkey keyword to after_passkey_authentication
#26
Conversation
@tcannonfodder let me know if I should add any tests |
Yep, we definitely need tests for this 💪 |
@tcannonfodder I see in a rails user model a comment saying we're checking that the validations were confirmed(here) but I wasn't able to find where do we actually check that 🥲 . Could you point me in the right direction? In the meanwhile, I've added tests for this callback into reauthentication integration test. |
I...actually don't know if we're using those checks 😅. I need to dig into the tests. It's one of the places where devise gets gnarly because of how it's designed |
Okay, it looks like that code is vestigial, from a previous implementation attempt. We should remove it in a subsequent PR |
Waiting on CI to pass, but looks good! 💪 |
Ack, @Vagab can you rebase the latest |
d92e9cc
to
48a7553
Compare
resolves #14