Skip to content

Commit

Permalink
SessionsControllerConcern.relying_party raises NoMethodError
Browse files Browse the repository at this point in the history
* This ports the changes to `ReauthenticationControllerConcern` to match
	for consistency
	* see: 447e114
	* #27
  • Loading branch information
tcannonfodder committed Jun 24, 2023
1 parent 447e114 commit 91a3bbe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def new_challenge
protected

def relying_party
raise "need to define relying_party for this SessionsController"
raise NoMethodError, "need to define relying_party for this #{self.class.name}"
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ def resource_name
Rails.application.reload_routes!
end

test "#new_challenge: raises RuntimeError if set_relying_party_in_request_env has not been implemented" do
assert_raises RuntimeError do
test "#new_challenge: raises RuntimeError if relying_party has not been implemented" do
assert_raises NoMethodError do
post "/session/new_challenge"
end
end
Expand Down

0 comments on commit 91a3bbe

Please sign in to comment.