Add exists? to fallbacks backend #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me @gschlager. Just waiting on the Travis build to go green. |
|
Looks like Travis isn't happy with your branch. I've got one called pr-326 which is up-to-date with the latest master which should make it happy. I'll wait for this one to go green. |
|
Just merged pr-326 to master. Thanks @gschlager! |
|
Hello, we used to rely on the fact that |
|
Hi @toncid, please open a new issue regarding this with steps to reproduce the behaviour that you were dependent on and I can take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n.exists?andI18n.translateshould behave the same when theFallbacksbackend is used.This adds the
exists?method to theFallbacksbackend, so thatI18n.exists?returnstruewhen the key exists in one of the fallback locales. Up until now it always returnsfalsewhen the key doesn't exist in the given locale, even though a call totranslatewould actually return a value.