Reset endpoint options between calls

[yesmeck]

I'm using Grape and Rable with grape-rabl gem, I have following code:

class Comments < Grape::API
  resources :comments do
    post do
      comment = Comment.new(params)
      if comment.save
        render rabl: 'comments/show'
      else
        car.errors.to_hash
      end
    end
  end
end

When first request save the comment succesfully, whatever the nex request save the comment succesfully or not, the rabl template will alway be rendered. Because grape-rabl write the template info to the endpoint options (https://github.com/LTe/grape-rabl/blob/master/lib%2Fgrape-rabl%2Frender.rb#L4), so I thinks the endpoint options should be reset between calls.

[dblock]

I am 50/50 on this. Endpoint options could very well survive requests, since the endpoint isn't supposed to change. We could freeze it explicitly?

I think grape-rabl should be using ENV. Could you open an issue there, please?

Either way this needs a CHANGELOG and the rubocop build to be fixed, please.

[yesmeck]

If endpoint isn't supposed to change, I think we can just make the endpoint options read only.

I have open an issue on grape-rabl.

[yesmeck]

It seems grape-rabl is hard to store template info in env directly, because when we write code like get '/', rabl: 'index', the template info is have to be stored in route_options.

[dblock]

I think the declarative part should be stored on the endpoint, but the runtime part should not.

[yesmeck]

@dblock Yes, I figured it out, I'm composing a new PR to grape-rabl.

[yesmeck]

As ruby-grape/grape-rabl#36 merged, should we still need to freeze the @options or make it read only? If the answer is yes, grape will not compatible with old version grape-rabl before 0.3.1.

[dblock]

IMO, I think we should keep it as is.

[dblock]

Closing this, LMK if you think we should still do something here.