Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requiring non-existent fields when using Grape::Entity documentation #673

Merged
merged 1 commit into from
Jul 5, 2014

Conversation

qqshfox
Copy link
Contributor

@qqshfox qqshfox commented Jul 4, 2014

When requires :none, except: [:non_existent_field], using: documentation, it may generate the params like this

{
    "paramType": "form",
    "name": "non_existent_field",
    "description": null,
    "type": "String",
    "dataType": "String",
    "required": true
},
{
    "paramType": "path",
    "name": "",
    "description": null,
    "type": "String",
    "dataType": "String",
    "required": true
},
{
    "paramType": "form",
    "name": "required_field",
    "description": null,
    "type": "String",
    "dataType": "String",
    "required": false
}

@dblock
Copy link
Member

dblock commented Jul 4, 2014

Thanks. Could you please update CHANGELOG and squash this?

@qqshfox qqshfox changed the title avoid requiring a non-existent field Avoid requiring non-existent fields when using Grape::Entity documentation Jul 4, 2014
@qqshfox
Copy link
Contributor Author

qqshfox commented Jul 4, 2014

rebased.

dblock added a commit that referenced this pull request Jul 5, 2014
Avoid requiring non-existent fields when using Grape::Entity documentation
@dblock dblock merged commit 2099c3a into ruby-grape:master Jul 5, 2014
@dblock
Copy link
Member

dblock commented Jul 5, 2014

Merged, Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants