Don't create Grape::Request multiple times. #512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a simple API call we're manufacturing the
Grape::Request
object many times..request
in the API.The first one could easily be fixed by storing @request ||= Grape::Request.new, but each middleware and API call would still continue to creating its own request object if it needed one.
This PR attempts to solve that cleanly:
Base.request
.Grape::Request
from the base class, use its own.Grape::Request
from the base class, use its own.Will leave this open for a bit for some comments, /cc: @mbleigh.