Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YARD docs markdown rendering #2310

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

duffn
Copy link
Member

@duffn duffn commented Mar 19, 2023

This fixes the rendering of the YARD docs in markdown. RudyDoc reads .yardopts so this will work there too.

As one small example:

Before

Screen Shot 2023-03-18 at 6 57 36 PM

After

Screen Shot 2023-03-18 at 6 58 56 PM

@duffn duffn force-pushed the duffn/code-docs branch from b5fe888 to 12c90eb Compare March 19, 2023 01:25
@dblock
Copy link
Member

dblock commented Mar 19, 2023

Looks like there's an unrelated rubocop failure, care to fix so we can get a green build?

@duffn
Copy link
Member Author

duffn commented Mar 20, 2023

Failures are now due to

https://github.com/rack/rack-test/blob/main/History.md#210--2023-03-14

Digest authentication support, deprecated in 2.0.0, has been removed (Jeremy Evans #307)

Digest authentication has been discussed as being removed as a breaking change here: #2294. So, we should continue to test for it. Will open a PR.

@duffn
Copy link
Member Author

duffn commented Mar 20, 2023

#2311

@dblock dblock merged commit d6b26af into ruby-grape:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants