Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happy Rubocop #2057

Closed
wants to merge 1 commit into from
Closed

happy Rubocop #2057

wants to merge 1 commit into from

Conversation

dnesteryuk
Copy link
Member

I don't know why but it became failing on Travis CI, locally everything was fine even with the latest version of Rubocop 🤔

@grape-bot
Copy link

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#2057](https://github.com/ruby-grape/grape/pull/2057): Happy rubocop - [@dnesteryuk](https://github.com/dnesteryuk).

Generated by 🚫 danger

@dnesteryuk
Copy link
Member Author

Doesn't make any sense anymore

@dnesteryuk dnesteryuk closed this May 26, 2020
@dnesteryuk dnesteryuk deleted the happy_rubocop branch May 26, 2020 16:57
@dblock
Copy link
Member

dblock commented May 26, 2020

Oh I didn't see this! Fixed in #2060.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants