Update rubocop #2003
Merged
Update rubocop #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rubocop-performance Added entry CHANGELOG.md
ericproulx
force-pushed
the
update_rubocop
branch
from
05dd6bf to
a7f90bb
Compare
dblock
reviewed
Mar 1, 2020
Gemfile
Outdated
| @@ -10,7 +10,8 @@ group :development, :test do | |||
| gem 'bundler' | |||
| gem 'hashie' | |||
| gem 'rake' | |||
| gem 'rubocop', '0.51.0' | |||
| gem 'rubocop' | |||
There was a problem hiding this comment.
We don't commit Gemfile.lock, so you should specify a version here or future builds will break for no reason as newer versions get released.
dblock
reviewed
Mar 1, 2020
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| #### Features | |||
|
|
|||
| * Your contribution here. | |||
| * [#2003](https://github.com/ruby-grape/grape/pull/2003): Updated rubocop - [@ericproulx](https://github.com/ericproulx). | |||
ericproulx
force-pushed
the
update_rubocop
branch
2 times, most recently
from
bc4186a to
79825f2
Compare
Ran appraisal clean Ran appraisal generate Re-ran rubocop Put back rack1 and rack2 gemfile I followed the naming convention of Appraisals Added autogen appraisals file
ericproulx
force-pushed
the
update_rubocop
branch
from
74cb2f9 to
0378840
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rubocop to latest version.
I also added rubocop-performance