Raise validation error when optional Hash type parameter is received String type value and exactly_one_of be used #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase#scope_requires_params to handle nested invalid parameter
|
Looks good, needs a |
|
@dblock I've applied a rubocop lint and add a entry to CHANGELOG.md. |
|
Great branch name! ;) |
basjanssen
pushed a commit
to basjanssen/grape
that referenced
this pull request
Feb 28, 2020
…String type value and exactly_one_of be used (ruby-grape#1822) * adds test for exactly_one_of validator with nested and optional parmeters * add check if the parameter responds to any? method in MultipleParamsBase#scope_requires_params to handle nested invalid parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec and fixes #1821 .
When String type was given instead of Hash type value, the item in scoped_params becomes String type and will be crashed due to not having any? method.