Support more options in desc block #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y`, `hidden`, `deprecated`, `is_array`, `nickname`,`produces`, `consumes`, `tags` options in desc block.
darren987469
force-pushed
the
support_more_options_in_desc_block
branch
from
7858d71 to
89c4d2c
Compare
|
Rubocop needs a |
dblock
reviewed
Sep 15, 2018
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| #### Features | |||
|
|
|||
| * Your contribution here. | |||
| * [#1791](https://github.com/ruby-grape/grape/pull/1791): Support more options in desc block - [@darren987469](https://github.com/darren987469). | |||
There was a problem hiding this comment.
Maybe quote desc.
Are these just "more" options, all options, specific options? All kinds of specific options? I am nitpicking but "more" isn't telling me much.
darren987469
force-pushed
the
support_more_options_in_desc_block
branch
from
f02aac2 to
b2f1fb2
Compare
darren987469
force-pushed
the
support_more_options_in_desc_block
branch
from
b2f1fb2 to
ab66701
Compare
|
Thanks for the comments. I fixed. Please take a look again, thanks! |
Add real mime type in README. Add options documentation in `desc`.
|
Merged thanks! |
This was referenced Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1789.
Support
summary,hidden,deprecated,is_array,nickname,produces,consumes,tagsoptions in desc block.