Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example #1780

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Fix example #1780

merged 1 commit into from
Aug 14, 2018

Conversation

glaucocustodio
Copy link
Contributor

The class method decode does not exist for Base64.

The class method `decode` does not exist for `Base64`.
@grape-bot
Copy link

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#1780](https://github.com/ruby-grape/grape/pull/1780): Fix example - [@glaucocustodio](https://github.com/glaucocustodio).

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Aug 14, 2018

This is a good opportunity to ask the question whether we think calling method is OK here. It causes the service not to start because the method doesn't exist, maybe it should always be a lambda?

@glaucocustodio
Copy link
Contributor Author

I think it is good to support method because give devs more possibilities. It seems good to me as well the service not to start because the method does not exist, it is easier to point errors.

@dblock dblock merged commit 292976d into ruby-grape:master Aug 14, 2018
@dblock
Copy link
Member

dblock commented Aug 14, 2018

Merged

@glaucocustodio glaucocustodio deleted the patch-1 branch August 14, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants