Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param aliases within 'given' blocks #1771

Merged
merged 3 commits into from
Jul 23, 2018

Conversation

jereynolds
Copy link
Contributor

Spec to display behavior of #1769 (as requested in that issue)

@dblock
Copy link
Member

dblock commented Jul 20, 2018

Thanks. We don't need a changelog for the spec since it's not going to be merged without a fix. But now that you have a spec you can try a fix? :)

@jereynolds jereynolds changed the title Add spec for param aliases with 'given' blocks Fix param aliases within 'given' blocks Jul 20, 2018
@dblock
Copy link
Member

dblock commented Jul 23, 2018

Great job! Merging.

@dblock dblock merged commit a152d98 into ruby-grape:master Jul 23, 2018
@jereynolds jereynolds deleted the alias-in-given-block branch July 27, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants