Failing test to expose a declared params bug #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be diving in to try and figure out whats wrong, but if this is expected behavior or someone has some hints about a fix, please let me know. |
bmarini
force-pushed
the
nested-declared-params-bug
branch
from
3471b8b to
dc43f81
Compare
|
Well, I got the tests to pass, BUT I doubt the way I fixed it is the right approach. The problem is I don't really understand the difference between The fix was: # Declared params including parent namespaces
all_declared_params = route_setting(:saved_declared_params).flatten | Array(route_setting(:declared_params))
# Declared params at current namespace
current_namespace_declared_params = route_setting(:saved_declared_params).last & Array(route_setting(:declared_params)) |
14 similar comments
bmarini
force-pushed
the
nested-declared-params-bug
branch
from
de0ec0d to
44d4c35
Compare
6 similar comments
5 similar comments
|
Same issue as #1544 looks like. |
|
I think this is fine, I'm going to merge it. The saved declared params are just whatever was there at endpoint construction, see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on enforcing declared params usage in my codebase, and in doing so I started running into issues where I thought a declared param should be available via a parent scope, but for some reason wasn't.
This is one of those cases. It works as expected if I remove the route defined just above the namespace 'foo'.