Enable to use custom helpers in error middleware, closes #438 #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1292,6 +1292,20 @@ def three | |||
| expect { get '/exception' }.to raise_error(RuntimeError, 'rain!') | |||
| end | |||
|
|
|||
| it 'should be able to use custom helpers defined by using #helpers method' do | |||
|
This looks good to me. Update CHANGELOG please, squash commits. Maybe needs a README change, if you find any suitable place. |
|
@dblock Thank you. Fixed and force pushed. |
|
Merged via 951ae51 (slightly amended text). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, everyone.
I'd love to use custom helpers in the Error middleware.
This change might be able to close #438 issue.
Could you review this?
Thanks.