-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rescue all header versioning regression #1114
Fix rescue all header versioning regression #1114
Conversation
The code looks good, but I am confused to what the spec failures mean - are the specs wrong? If so they need to change. Also please update CHANGELOG and squash the commits. |
I am curious what @dm1try thinks about this. Also, this definitely needs to be documented in both README and the behavior change in UPGRADING. Finally, maybe we need to make this behavior configurable? |
@dblock The spec failures show that with my changes it's (unfortunately) not possible to rescue any |
The changes seem good to me. All failing tests are invalid and did not regard the scenario as defined in the related issue. |
@suan remove the bad tests, squash the commits please, update README, UPGRADING and CHANGELOG. |
6793b57
to
54fbbf3
Compare
54fbbf3
to
2fa517c
Compare
@dblock I've made the suggested changes - let me know if there's anything you'd need, thanks! |
This is good, merging. |
…egression Fix rescue all header versioning regression
Awesome, appreciate it @dblock! |
A suggested fix for #968
There are two failing specs which show that unfortunately there is no way to
rescue_from
an invalid version, since it's possibly valid and needs to propogate. This was also the case before the regression was introduced.