Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 -> 1.6.1 contains breaking change #2230

Closed
ro-savage opened this issue Jan 4, 2022 · 9 comments
Closed

1.6.0 -> 1.6.1 contains breaking change #2230

ro-savage opened this issue Jan 4, 2022 · 9 comments

Comments

@ro-savage
Copy link

Our automated tests are showing

rake aborted!
NameError: uninitialized constant Grape::Validations::Base

It appears this commit 937b2fc changed the path from Grape::Validations::Base to Grape::Validations::Validators:Base

@dm1try
Copy link
Member

dm1try commented Jan 4, 2022

yeah, sorry for that.

sadly, after the release I noticed that the UPGRADING.md had not been updated in #2200. so I didn't expect any breaking change from such refactoring.

I'm closing, there is nothing we can do here.

@dm1try dm1try closed this as completed Jan 4, 2022
@dm1try
Copy link
Member

dm1try commented Jan 4, 2022

though, we can create a patch for compatibility with 1.6.0 and up a minor version

Grape::Validations::Base = Grape::Validations::Validators:Base

@ro-savage
Copy link
Author

@dm1try - We've updated our codebase to use Grape::Validations::Validators:Base
But I think it make sense to release 1.6.3 that contains this - so that the latest 1.6.x isn't a breaking change from 1.6.0

@dblock
Copy link
Member

dblock commented Jan 5, 2022

@dm1try - We've updated our codebase to use Grape::Validations::Validators:Base
But I think it make sense to release 1.6.3 that contains this - so that the latest 1.6.x isn't a breaking change from 1.6.0

This was a miss. Care to PR this fix @ro-savage ?

@ro-savage
Copy link
Author

@dblock - Unfortunately I am not a ruby developer, I actually wouldn't know where to put the alias.

@dm1try dm1try reopened this Jan 5, 2022
@Jack12816
Copy link
Contributor

:( Breaking change in a patch version. This does not only affect Grape::Validations::Base, but also users who extended existing built-in validators or compositions of it. This is even worse for external package maintainers who rely on the constants.

@dblock
Copy link
Member

dblock commented Feb 17, 2022

Agreed. Can someone please PR a fix? @dm1try ?

@dm1try
Copy link
Member

dm1try commented Feb 17, 2022

@dblock take a look at #2244

dm1try added a commit to dm1try/grape that referenced this issue Feb 19, 2022
@dblock
Copy link
Member

dblock commented Oct 8, 2024

Closed via #2244.

@dblock dblock closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants