Grape 1.6.1 throughs an error on Grape::Validations::Types.group?()

[mobilutz]

The patch upgrade from 1.6.0 to 1.6.1 is breaking on the following line for me:
https://github.com/ruby-grape/grape/blob/v1.6.1/lib/grape/dsl/parameters.rb#L154

The full error is:

An error occurred while loading ./spec/riskmethods/jsonapi/validations_spec.rb.
Failure/Error:
  optional :hash, type: ::Hash, strict_hash: true do
    optional :nested
  end

NoMethodError:
  undefined method `group?' for Grape::Validations::Types:Module
# ./vendor/bundle/ruby/2.7.0/gems/grape-1.6.1/lib/grape/dsl/parameters.rb:154:in `optional'

Even though, def self.group?() is defined on Types here, I cannot call it through IRB or any other other means:
https://github.com/ruby-grape/grape/blob/v1.6.1/lib/grape/validations/types.rb#L101-L108

Looking through our specs, I also find this error:

NoMethodError:
  undefined method `multiple?' for Grape::Validations::Types:Module
# ./vendor/bundle/ruby/2.7.0/gems/grape-1.6.1/lib/grape/validations/params_scope.rb:359:in `infer_coercion'

The test setup is as follows:

1. create a RSpec support app with some endpoints and optional params e.g.

      params do
        optional :hash, type: ::Hash, strict_hash: true do
          optional :nested
        end
      end
   
      get :strict_hash do
        ...
      end
   

2. call that endpoint in specs
3. see error from grape 😦

PS: In my opinion, the patch update has way to many changes in it to be honest. But I also know how hard maintaining an open-source product is, so please don't take this as a complaint!

[dm1try]

@mobilutz thanks for the report!
@ericproulx could you take a look please? it might be related to the latest changes was made for autoloading.

[dblock]

@mobilutz appreciate if you could please turn your repro into a failing spec PR

[dm1try]

@dblock I've discovered that it's easy enough, just remove eager_load from spec_helper to reproduce the problem

[dm1try]

it might be worth removing it at all if we have an integration spec for eager_load => https://github.com/ruby-grape/grape/blob/master/spec/integration/eager_load/eager_load_spec.rb

[dm1try]

@mobilutz meanwhile, as a workaround, you could put

require 'grape/eager_load'
Grape::Validations.eager_load!
Grape::Validations::Validators.eager_load!

in the spec helper

but I'm hoping for a quick fix release :)

[seb-sykio]

I am not sure if the problem is similar : I have this error after update from 1.6 to 1.6.1

undefined method multiple?' for Grape::Validations::Types:Module .rvm/gems/ruby-3.0.3/gems/grape-1.6.1/lib/grape/validations/params_scope.rb:359:in infer_coercion'
.rvm/gems/ruby-3.0.3/gems/grape-1.6.1/lib/grape/validations/params_scope.rb:274:in validates' .rvm/gems/ruby-3.0.3/gems/grape-1.6.1/lib/grape/validations/params_scope.rb:195:in validate_attributes'
.rvm/gems/ruby-3.0.3/gems/grape-1.6.1/lib/grape/dsl/parameters.rb:160:in optional' ./app/controllers/api/v1/addresses.rb:12:in block (2 levels) in class:Addresses'

the code is
` resource :addresses do

    desc "List all addresses"
    params do
      optional :market_id, type: String, desc: "ID of the market"
    end`

[dm1try]

@seb-sykio yeah, it looks like the same problem.

[dm1try]

I propose to revert the latest changes that were made to the autoloading in #2207 #2209 and release again.

At least, the changes for validators will not work as expected because the grape validators are loaded differently(we do not use a class name but use some :symbol in DSL) so we cannot use a standard autoload interface.
not sure about the part with Types autoloading but it looks like it's a problem too^

[dblock]

I propose to revert the latest changes that were made to the autoloading in #2207 #2209 and release again.

At least, the changes for validators will not work as expected because the grape validators are loaded differently(we do not use a class name but use some :symbol in DSL) so we cannot use a standard autoload interface. not sure about the part with Types autoloading but it looks like it's a problem too^

That works for me.

[mobilutz]

Thanks for working on this so fast.
I will test out, if the proposed idea helps us. But I also think it is better to not have a workaround.

If you need any help with a test setup, I can see to create an app for you guys.

Cheers

[ericproulx]

Sorry for the late reply, I was out all day. I’ll take a look tomorrow and let you know.

…

On Wed 29 Dec 2021 at 22:52 Lutz Lengemann ***@***.***> wrote: Thanks for working on this so fast. I will test out, if the proposed idea helps us. But I also think it is better to not have a workaround. If you need any help with a test setup, I can see to create an app for you guys. Cheers — Reply to this email directly, view it on GitHub <#2214 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAHJI5ZACFNXHIJ32E5G2DUTN7I5ANCNFSM5K5S2SVA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Avertissement*
 Ce message est destiné uniquement à la personne ou à l’organisation à laquelle il est adressé et il peut contenir des informations privilégiées, confidentielles ou non divulgables en vertu de la loi. Si vous n’êtes pas le destinataire du présent message ni la personne chargée de remettre le présent message à son destinataire, il vous est strictement interdit de le divulguer, de le distribuer, de le copier ou de l’utiliser de quelque façon que ce soit. Si vous avez reçu la présente communication par erreur, veuillez en aviser l’expéditeur et détruire ou effacer tous les exemplaires que vous avez reçus.
 *Warning
 *This message is intended only for the use of the individual or entity to which it is addressed, and may contain information which is privileged, confidential, proprietary or exempt from disclosure under applicable law. If you are not the intended recipient or the person responsible for delivering the message to the intended recipient, you are strictly prohibited from disclosing, distributing, copying or in any way using this message. If you have received this communication in error, please notify the sender, and destroy and delete any copies you may have received.

[dm1try]

@ericproulx it's a holiday time and I think we don't need any rush here, so I'm going to release the fix with reverted #2207 #2209. If you come with some solution then it will be released the next time :)

[dm1try]

1.6.2 has been released, try updating 🤞🏻

[sharq1]

Upgrading to 1.6.2 fixed the related issue #2218 - thank you!

[mobilutz]

Thanks @dm1try