Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi_json gem version requirement #185

Closed
flah00 opened this issue Jun 12, 2012 · 2 comments
Closed

multi_json gem version requirement #185

flah00 opened this issue Jun 12, 2012 · 2 comments
Labels
feature request

Comments

@flah00
Copy link
Contributor

flah00 commented Jun 12, 2012

Someone more familiar with the multi_json code base should update the gemspec, to include a minimum version for multi_json. It appears that MultiJson#dump is relatively new (4/12) and the lack of a version causes issues for people with older versions. I know 1.3.6 has #dump, but I'm uncertain what the minimum version is... I could submit a PR for version 1.3.6, but that seems inaccurate and therefore unwanted.
@dblock
Copy link
Member

dblock commented Jul 21, 2012

I would track down when ``dumpwas introduced, make sure Grape tests fail with the version before and then add a>=` in gemspec. I bet it's 1.3.5, but I wouldn't bet on it :)

gruis added a commit to gruis/grape that referenced this issue Sep 26, 2012
@gruis
refs: ruby-grape#185 gemspec requires multi_json >= 1.3.2
885e74c 
MultiJson.dump was introduced in version 1.3.2.

An alternative approach would be to use MultiJson.encode if
MultiJson.dump is not available.
dblock added a commit that referenced this issue Sep 26, 2012
@dblock
Merge pull request #250 from simulacre/185_multi_json_version
03fe2d5 
refs: #185 gemspec requires multi_json >= 1.3.2
@dblock
Copy link
Member

dblock commented Sep 26, 2012

Locked at >= 1.3.2 in gruis@885e74c

@dblock dblock closed this as completed Sep 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flah00 @dblock