Roar decorator support #10
Conversation
| end | ||
| ``` | ||
|
|
||
| Note this issue when using decorators: https://github.com/apotonick/roar/issues/92 |
There was a problem hiding this comment.
I am not 100% sure this is necessary, but if you think it is, I would describe it here fully and then provide a link.
There was a problem hiding this comment.
I was thinking that it is pretty helpful and will hopefully save people having to look up why their code isn't working/save an issue on this repo. Having said that, it would be better if it was documented on roar itself. I'll leave that out for now.
|
This is great, thanks! Needs a CHANGELOG entry and a build fix (Rubocop), please. Also would appreciate it if you could squash the commits. |
|
Before I squash, is everything 100%? version 0.1.1, CHANGELOG entry etc. |
| @@ -1,3 +1,8 @@ | |||
| 0.1.1 (18/12/2014) | |||
There was a problem hiding this comment.
This should have a TBD date, otherwise people think it's released. I usually don't put a version in here either, so would just say Next.
|
I added some very nitpicky comments. Thanks for your patience. |
|
I can't stop thinking about how we misspell Roar now and how it should be ROAR being an acronym:) j/k, but cc: @apotonick |
|
Haha, OCD is a b%$#h - nitpicking is no problem glad I could help :) |
|
This is good, squash and I'll merge. |
|
Closing in favour of #11 |
|
I gave a talk What is Roar and why does Katy Perry sing about it? and now she wants to marry me: https://twitter.com/apotonick/status/421250134140137472 |
|
@apotonick Katy sends you her love. |
|
Thanks @dblock. Kisses back 💋 |
Added
Grape::Roar::Decoratorto allow the decorator pattern to be used in grape.Please see updated README for details.
Thanks!