-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't suppress regular ArgumentError exceptions #366
Conversation
Account specifically for the following scenario: expose :foo, &:bar Note that `:bar.to_proc.parameters` always returns `[[:req], [:rest]]`. We should not swallow ArgumentError exceptions in any other instance.
👋 @LeFnord Do you mind reviewing this PR? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 … that makes sense … good improvement
@splattael … please, can you run |
@LeFnord Whoops, done ✔️ Thanks for the heads-up 🙇 |
avoid calling of and you can also change |
What do you mean by this? 🤔
So, should we replace |
sorry … mean it here spec_helper.rb
replace |
dbe0dc0
to
94c235e
Compare
I still don't follow. Should I delete SimpleCov? 🤔
OK, done but honestly I don't understand why we stop testing on Ruby 3.0 🤷 It is still being maintained. |
sorry my fault … yes you are right 3.0 is maintained … so re-add 3.0 and comment out the |
94c235e
to
c3125cc
Compare
No worries, done 👍
Oh now I saw it fails on Ruby >= 3.1 due to simplecov-ruby/simplecov#1003 and thus cancels all other runs 🤦 I've disabled SimpleCov on Ruby >= 3.1 then so checks should pass soon 🤞 |
Account specifically for the following scenario:
Note that
:bar.to_proc.parameters
always returns[[:req], [:rest]]
.We should not swallow ArgumentError exceptions in any other instance.
See spec for an example.