Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use 2.5.7, 2.6.5, 2.7.0 #330

Merged
merged 2 commits into from
Feb 18, 2020
Merged

CI: Use 2.5.7, 2.6.5, 2.7.0 #330

merged 2 commits into from
Feb 18, 2020

Conversation

budnik
Copy link
Contributor

@budnik budnik commented Feb 17, 2020

Previous attempt to update matrix failed because rubocop version is not fixed so ~> 0.65 resolved to version above 0.75. I guess it was mistake not to define it as ~> 0.65.0

Last version of rubocop passing is 0.74 so fixing that version.
Bumping of rubocop could be addressed in own PR.

@budnik budnik requested a review from LeFnord February 17, 2020 10:53
.travis.yml Show resolved Hide resolved
Gemfile Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 17, 2020

Coverage Status

Coverage remained the same at 95.869% when pulling d837a59 on budnik:patch-1 into 96afd88 on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Feb 17, 2020

will close #318 in favour of this one

@olleolleolle
Copy link
Contributor

I really appreciate the work on bringing this forward! ✨

@budnik budnik changed the title CI: Use 2.4.9, 2.5.7, 2.6.5 CI: Use ~2.4.9,~ 2.5.7, 2.6.5, 2.7.0 Feb 18, 2020
@budnik budnik changed the title CI: Use ~2.4.9,~ 2.5.7, 2.6.5, 2.7.0 CI: Use 2.5.7, 2.6.5, 2.7.0 Feb 18, 2020
@budnik budnik requested a review from LeFnord February 18, 2020 12:24
@LeFnord
Copy link
Member

LeFnord commented Feb 18, 2020

thanks @budnik

@LeFnord LeFnord merged commit a4cb98f into ruby-grape:master Feb 18, 2020
@budnik budnik deleted the patch-1 branch February 18, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants