-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expose_nil option #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@b-boogaard you can increase |
351d35b
to
ad4f114
Compare
* Adds expose_nil option - [@b-boogaard](https://github.com/b-boogaard) * [#288](https://github.com/ruby-grape/grape-entity/pull/288) Fix wrong argument exception when &:block passed to the expose method - [@DmitryTsepelev](https://github.com/DmitryTsepelev). * [#291](https://github.com/ruby-grape/grape-entity/pull/291) Refactor and simplify various classes and modules - [@DmitryTsepelev](https://github.com/DmitryTsepelev). Generated by 🚫 danger |
* [#291](https://github.com/ruby-grape/grape-entity/pull/291) Refactor and simplify various classes and modules - [@DmitryTsepelev](https://github.com/DmitryTsepelev). * [#288](https://github.com/ruby-grape/grape-entity/pull/288) Fix wrong argument exception when &:block passed to the expose method - [@DmitryTsepelev](https://github.com/DmitryTsepelev). Generated by 🚫 danger |
* expose_nil defaults to true * is implemented as an unless condition * the option is transformed as part of Exposure.compile_conditions
ad4f114
to
5feb848
Compare
@DmitryTsepelev I updated the |
thanks @b-boogaard |
Sure thing @LeFnord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #216 and #10
I read through both of the issues to help guide naming, default behavior etc.
Some basic high level details
Currently rubocop is failing because my new tests make the
describe
block too long. I'm not sure how you all typically handle something like this so just let me know what I should do.