-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop cleanup #264
Rubocop cleanup #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks … please can you also adapt the rubocop version in the gem spec, thanks
.rubocop.yml
Outdated
@@ -1,6 +1,30 @@ | |||
AllCops: | |||
TargetRubyVersion: 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change it to 2.4, maybe also in the grape
please run |
thanks @james2m |
FWIW I generally just stick to |
Adds a Rubocop config for 0.48.1 based on the config from grape, and update the todo list for the existing offences. I don't have time to fix all those issues so I suggest tackling the todo should be a separate PR.