Avoid noise when code runs with Ruby warnings #251
Conversation
cpetschnig
force-pushed
the
avoid_ruby_warnings
branch
from
0416fe4 to
55b84cd
Compare
| @@ -2,11 +2,11 @@ | |||
|
|
|||
| #### Features | |||
|
|
|||
| * Your contrbution here. | |||
| * Your contribution here. | |||
|
|
||
| #### Fixes | ||
|
|
||
| * Your contrbution here. |
There was a problem hiding this comment.
please re-add it below your contribution
|
thanks @cpetschnig for contributing, please see my comment above |
| config.raise_errors_for_deprecations! | ||
|
|
||
| config.warnings = true | ||
| end |
There was a problem hiding this comment.
@LeFnord maybe this should be enabled?
@ cpetchnig do we get a pass with all the changes you made and another setting to fail the build if warnings? if so I recommend doing that
There was a problem hiding this comment.
@dblock this would enable the warnings and makes also the specs noisy, maybe they could be used for writing better code, but think for that we have rubocop, so by enabling it, we have two of such tools … mmh
if they both give the same or similar warnings, then one is enough and the rubocop messages much more helpful, IMHO the rspec warnings are higher level and helpful for experienced devs, but they also raises the barrier for contributions
if not then it should be disabled
New versions of RSpec have warnings turned on by default:
# This setting enables warnings. It's recommended, but in some cases may
# be too noisy due to issues in dependencies.
config.warnings = true
I believe these warnings are helpful in general to write better code. However, Grape Entity is very noisy. I get more than 10 lines of warnings for one single test where Grape Entity is involved.
I hope you agree. Some of my changes could also be solved differently for sure. I am happy to discuss and change those cases. I also turned warnings on in the test suite.
cpetschnig
force-pushed
the
avoid_ruby_warnings
branch
from
55b84cd to
031a710
Compare
Generated by 🚫 danger |
|
Thank you for your feedback. I have updated the PR. |
|
👍 |
New versions of RSpec have warnings turned on by default:
I believe these warnings are helpful in general to write better code. However, Grape Entity is very noisy. I get more than 10 lines of warnings for one single test where Grape Entity is involved.
I hope you agree. Some of my changes could also be solved differently for sure. I am happy to discuss and change those cases. I also turned warnings on in the test suite.