Namespace inferred serializer resolution. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,5 +24,5 @@ Gem::Specification.new do |gem| | |||
| gem.add_development_dependency 'rack-test' | |||
| gem.add_development_dependency 'rake' | |||
| gem.add_development_dependency 'guard-rspec' | |||
| gem.add_development_dependency 'rubocop', '0.28.0' | |||
| gem.add_development_dependency 'rubocop' | |||
There was a problem hiding this comment.
This will cause problems. You can move it out of gemspec and into the Gemfile, but you want a version or in the future bundle install brings a newer one and suddenly things fail.
There was a problem hiding this comment.
Good call. I kept it in the .gemspec but locked the version here. Pushed it straight to master, as it's a small change
|
Merging. See my comment on Rubocop, can address later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements the changes in pull #58 on top of the refactor of pull #59.
This borrows some logic from the serializer resolution logic in active_model_serializers. Given that active_model_serializers no longer supports the
namespaceoption passed into theserializer_formethod, in order to support namespace inference we need to reuse some of theirserializer_forlogic in grape-asm. I will work with the asm team to add back support for that option, but in order to support the existing 0.10.x asm versions, we need to reimplement some of that logic.