RSpec/UnspecifiedException: break on non-send blocks to avoid false positives on functions named raise_exception
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
approved these changes
Sep 22, 2024
bquorning
reviewed
Sep 23, 2024
|
Can I ask you for a review @pirj ? |
pirj
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Does it fix #1954, too? Can you please add a spec and a changelog entry, or remove this mention from the pr description?
I’d say the cop should be disabled and deprecated, but if you’re fine with fizing it, I have no objections, too.
Thank you!
aarestad
commented
Sep 25, 2024
bquorning
approved these changes
Sep 25, 2024
aarestad
force-pushed
the
unspecified-exception-fix
branch
5 times, most recently
from
8651d2a to
18e94a8
Compare
aarestad
force-pushed
the
unspecified-exception-fix
branch
from
18e94a8 to
a59315f
Compare
bquorning
approved these changes
Sep 26, 2024
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a false positive in the
UnspecifiedExceptioncop that is triggered when a function under test is literally calledraise_exceptionorraise_error.Resolves #1949.