[Fix #658] Fix a false positive for Rails/TransactionExitStatement
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_rails_transaction_exit_statement
branch
2 times, most recently
from
3bdd8df to
de664fa
Compare
koic
changed the title
Rails/TransactionExitStatementRails/TransactionExitStatement
sunny
reviewed
Mar 16, 2022
| @@ -43,4 +43,14 @@ | |||
| end | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'does not register an offense when `raise` is used in `loop` in transactions' do | |||
There was a problem hiding this comment.
Shouldn’t this refer to break rather than raise?
Suggested change
| it 'does not register an offense when `raise` is used in `loop` in transactions' do | |
| it 'does not register an offense when `break` is used in `loop` in transactions' do |
…ement` Fixes rubocop#658. This PR fixes a false positive for `Rails/TransactionExitStatement` when `break` is used in `loop` in transactions.
koic
force-pushed
the
fix_a_false_positive_for_rails_transaction_exit_statement
branch
from
de664fa to
583175c
Compare
koic
deleted the
fix_a_false_positive_for_rails_transaction_exit_statement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658.
This PR fixes a false positive for
Rails/TransactionExitStatementwhenbreakis used inloopin transactions.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.