Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #435] Fix a false negative for Rails/BelongsTo #438

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

koic
Copy link
Member

@koic koic commented Feb 9, 2021

Fixes #435.

This PR fixes a false negative for Rails/BelongsTo when using belongs_to lambda block with required option.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the fix_false_negative_for_rails_belongs_to branch 3 times, most recently from 000ccea to 0a21ec7 Compare February 9, 2021 20:32
Fixes rubocop#435.

This PR fixes a false negative for `Rails/BelongsTo`
when using `belongs_to` lambda block with `required` option.
@koic koic force-pushed the fix_false_negative_for_rails_belongs_to branch from 0a21ec7 to ea62fe5 Compare February 15, 2021 10:09
@koic koic merged commit 78b70fa into rubocop:master Feb 15, 2021
@koic koic deleted the fix_false_negative_for_rails_belongs_to branch February 15, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/BelongsTo does not work with scoped associations
1 participant