Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #384] Mark unsafe for Rails/NegateInclude #385

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

koic
Copy link
Member

@koic koic commented Nov 18, 2020

Fixes #384

This PR marks unsafe for Rails/NegateInclude because false positive will occur for a receiver object that do not have exclude? method. (e.g. IPAddr)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#384

This PR marks unsafe for `Rails/NegateInclude` because false positive
will occur for a receiver object that do not have `exclude?` method.
(e.g. `IPAddr`)
@koic koic force-pushed the mark_unsafe_for_rails_negate_include branch from b45f1f3 to b024858 Compare November 18, 2020 03:31
@koic koic merged commit 377195b into rubocop:master Nov 18, 2020
@koic koic deleted the mark_unsafe_for_rails_negate_include branch November 18, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/NegateInclude is not safe for auto correction
1 participant