[Fix #215] Fix a false positive for Rails/UniqueValidationWithoutIndex
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_unique_validation_without_index
branch
from
dcca9d1 to
cf056ef
Compare
…houtIndex` Fixes rubocop#215. This PR fixes a false positive for `Rails/UniqueValidationWithoutIndex` when using Expression Indexes for PostgreSQL. Since it is difficult to predict a kind of string described in Expression Indexes, this implementation judges based on whether or not an Expression Indexes include a column name. There is a possibility of false negative, but in most cases I expect it works. ## References - https://www.postgresql.org/docs/12/indexes-expressional.html - rails/rails@edc2b77
koic
force-pushed
the
fix_a_false_positive_for_unique_validation_without_index
branch
from
cf056ef to
ac766e3
Compare
koic
deleted the
fix_a_false_positive_for_unique_validation_without_index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215.
This PR fixes a false positive for
Rails/UniqueValidationWithoutIndexwhen using Expression Indexes for PostgreSQL.Since it is difficult to predict a kind of string described in Expression Indexes, this implementation judges based on whether or not an Expression Indexes include a column name.
There is a possibility of false negative, but in most cases I expect it works.
References
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.