[Fix #193] Make Rails/EnvironmentComparison aware of several comparisons
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_environment_comparison_aware_of_comparisons
branch
from
95dd59f to
37f87a0
Compare
… comparisons Fixes rubocop#193. This PR makes `Rails/EnvironmentComparison` aware of the following comparisons: - When `Rails.env` is used on RHS - When `!=` is used to compare with `Rails.env`
koic
force-pushed
the
make_environment_comparison_aware_of_comparisons
branch
from
37f87a0 to
87fdbe2
Compare
pocke
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193.
This PR makes
Rails/EnvironmentComparisonaware of the following comparisons:Rails.envis used on RHS!=is used to compare withRails.envBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.