[Fix #150] Add EnforcedStyle: refute for Rails/RefuteMethods
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_supported_style_refute_for_rails_refute_methods
branch
from
4a3f407 to
406b8d1
Compare
koic
force-pushed
the
add_supported_style_refute_for_rails_refute_methods
branch
from
406b8d1 to
d70a776
Compare
koic
force-pushed
the
add_supported_style_refute_for_rails_refute_methods
branch
from
d70a776 to
1abf72b
Compare
Fixes rubocop#150. This PR adds `EnforcedStyle: refute` for `Rails/RefuteMethods`. `EnforcedStyle: refute` is an alternative style to `EnforcedStyle: assert_not`. ```ruby # @example EnforcedStyle: refute # # bad # assert_not false # assert_not_empty [1, 2, 3] # assert_not_equal true, false # # # good # refute false # refute_empty [1, 2, 3] # refute_equal true, false ``` The default style keeps `EnforcedStyle: assert_not` because following the Rails coding conventions conventions. > Use `assert_not` methods instead of refute. https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions
koic
force-pushed
the
add_supported_style_refute_for_rails_refute_methods
branch
from
1abf72b to
8ce0fcd
Compare
|
awesome, thx! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150.
This PR adds
EnforcedStyle: refuteforRails/RefuteMethods.EnforcedStyle: refuteis an alternative style toEnforcedStyle: assert_not.The default style keeps
EnforcedStyle: assert_notbecause following the Rails coding style conventions..https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.