Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding #1414

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Jan 17, 2025

Prior to these changes, these examples would be marked as offenses:

# ruby >=3.2
def perform_request(**)
  get(:list, **)
end
# ruby >=2.7
def perform_request(...)
  get(:list, ...)
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@viralpraxis viralpraxis force-pushed the fix-rails-http-positional-arguments-cop-false-positives-on-forwarded-args branch 2 times, most recently from f87780f to 404e2e0 Compare January 17, 2025 13:52
@viralpraxis viralpraxis force-pushed the fix-rails-http-positional-arguments-cop-false-positives-on-forwarded-args branch from 404e2e0 to d47284e Compare January 17, 2025 13:53
@koic koic merged commit 047dee3 into rubocop:master Jan 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants