Fix Rails/FilePath cop error with rescued Rails.root
#1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Can you add a changelog entry and rebase with the latest master branch? |
viralpraxis
force-pushed
the
fix-rails-file-path-cop-error-with-rescued-rails-root
branch
from
74892f1 to
30529f0
Compare
```console
echo '"#{Rails.root rescue "."}/config"' | rubocop --stdin bug.rb -d
An error occurred while Rails/FilePath cop was inspecting bug.rb:1:0.
undefined method `method?' for an instance of RuboCop::AST::RescueNode
lib/rubocop/cop/rails/file_path.rb:156:in `autocorrect_slash_after_rails_root_in_dstr'
lib/rubocop/cop/rails/file_path.rb:81:in `block in check_for_slash_after_rails_root_in_dstr'
```
viralpraxis
force-pushed
the
fix-rails-file-path-cop-error-with-rescued-rails-root
branch
from
30529f0 to
bb03d6b
Compare
|
Thanks! |
viralpraxis
deleted the
fix-rails-file-path-cop-error-with-rescued-rails-root
branch
viralpraxis
added a commit
to viralpraxis/rubocop-rails
that referenced
this pull request
Dec 21, 2024
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
viralpraxis
added a commit
to viralpraxis/rubocop-rails
that referenced
this pull request
Dec 21, 2024
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
9 tasks
viralpraxis
added a commit
to viralpraxis/rubocop-rails
that referenced
this pull request
Dec 22, 2024
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
viralpraxis
added a commit
to viralpraxis/rubocop-rails
that referenced
this pull request
Dec 22, 2024
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
viralpraxis
added a commit
to viralpraxis/rubocop-rails
that referenced
this pull request
Dec 22, 2024
…root` interpolation Follow-up to rubocop#1392. Previous PR didn't fix cases like this ``` "#{Rails.root || '.'}/config" ``` (it makes sense in real code since `Rails.root` [can be nil](https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L65-L67)) I think it's safe to simply check if the entire expression is of `send` type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.