[Fix #204] Add Performance/Sum
option to ignore potential false positives
#271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some codebases may contain non-numeric classes which implement a
:+
method.If
a
,b
andc
are objects of such a class, then certain correctionsdo not apply:
For users who wish to only register offenses where auto-correction
is unproblematic, we add the option
OnlySumOrWithInitialValue
to the
Performance/Sum
cop.The option is disabled by default, so standard behavior is preserved,
and can be activated by setting
OnlySumOrWithInitialValue: true
.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.