Merge pull request #478 from viralpraxis/fix-performance-redundant-st…

…ring-chars-cop-error-in-case-of-implicit-receiver Fix `Performance/RedundantStringChars` cop error in case of implicit receiver
rubocop · Dec 11, 2024 · 9248192 · 9248192
2 parents 378299f + ccb9241
commit 9248192
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/...ix_performance_redundant_string_chars_cop_error_in_case_of_implicit_receiver.md b/...ix_performance_redundant_string_chars_cop_error_in_case_of_implicit_receiver.md
@@ -0,0 +1 @@
+* [#478](https://github.com/rubocop/rubocop-performance/pull/478): Fix `Performance/RedundantStringChars` cop error in case of implicit receiver. ([@viralpraxis][])
diff --git a/lib/rubocop/cop/performance/redundant_string_chars.rb b/lib/rubocop/cop/performance/redundant_string_chars.rb
@@ -48,7 +48,7 @@ class RedundantStringChars < Base
         RESTRICT_ON_SEND = %i[[] slice first last take length size empty?].freeze
 
         def_node_matcher :redundant_chars_call?, <<~PATTERN
-          (send $(send _ :chars) $_ $...)
+          (send $(send !nil? :chars) $_ $...)
         PATTERN
 
         def on_send(node)

diff --git a/spec/rubocop/cop/performance/redundant_string_chars_spec.rb b/spec/rubocop/cop/performance/redundant_string_chars_spec.rb
@@ -139,4 +139,10 @@
       str.chars.max
     RUBY
   end
+
+  it 'does not register an offense with implicit receiver' do
+    expect_no_offenses(<<~RUBY)
+      chars.size
+    RUBY
+  end
 end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#478](https://github.com/rubocop/rubocop-performance/pull/478): Fix `Performance/RedundantStringChars` cop error in case of implicit receiver. ([@viralpraxis][])