-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocorrection of heredocs is an error #42
Labels
bug
Something isn't working
Comments
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Dec 20, 2019
…est` Fixes rubocop#42. This PR fixes an incorrect autocorrect for the following cops when using heredoc message. * `Minitest/AssertIncludes` * `Minitest/RefuteIncludes` * `Minitest/AssertEmpty` * `Minitest/RefuteEmpty` * `Minitest/AssertEqual` * `Minitest/RefuteEqual` * `Minitest/AssertInstanceOf` * `Minitest/RefuteInstanceOf` * `Minitest/AssertRespondTo` * `Minitest/RefuteRespondTo` * `Minitest/AssertNil` * `Minitest/RefuteNil` * `Minitest/AssertTruthy` * `Minitest/RefuteFalse`
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Dec 20, 2019
…est` Fixes rubocop#42. This PR fixes an incorrect autocorrect for the following cops when using heredoc message. * `Minitest/AssertIncludes` * `Minitest/RefuteIncludes` * `Minitest/AssertEmpty` * `Minitest/RefuteEmpty` * `Minitest/AssertEqual` * `Minitest/RefuteEqual` * `Minitest/AssertInstanceOf` * `Minitest/RefuteInstanceOf` * `Minitest/AssertRespondTo` * `Minitest/RefuteRespondTo` * `Minitest/AssertNil` * `Minitest/RefuteNil` * `Minitest/AssertTruthy` * `Minitest/RefuteFalse`
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Dec 20, 2019
…est` Fixes rubocop#42. This PR fixes an incorrect autocorrect for the following cops when using heredoc message. * `Minitest/AssertIncludes` * `Minitest/RefuteIncludes` * `Minitest/AssertEmpty` * `Minitest/RefuteEmpty` * `Minitest/AssertEqual` * `Minitest/RefuteEqual` * `Minitest/AssertInstanceOf` * `Minitest/RefuteInstanceOf` * `Minitest/AssertRespondTo` * `Minitest/RefuteRespondTo` * `Minitest/AssertNil` * `Minitest/RefuteNil` * `Minitest/AssertTruthy` * `Minitest/RefuteFalse`
koic
added a commit
that referenced
this issue
Dec 23, 2019
…me_cops [Fix #42] Fix an incorrect autocorrect for some cops of `Minitest`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is observed for both
Minitest/AssertEmpty
andMinitest/AssertIncludes
.For example:
I'm using rubocop 0.74.0 and rubocop-minitest 0.5.0
The text was updated successfully, but these errors were encountered: