Introduce RuboCop::Ast::MethodDispatchNode#selector #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
selector-for-yield-and-super
branch
from
2414095 to
670df28
Compare
|
Thanks for the PR @gsamokovarov . No problem for I think this is a good idea, but would I would like to know what @koic thinks about it |
bbatsov
reviewed
May 31, 2023
|
For the record - it looks like a reasonable addition to me. Frankly, I don't see much point in |
If you need to manipulate the call-site of a method dispatch, you have to use node.loc.selector for regular methods and node.loc.keyword for syntax nodes that behave like method invocations, but are not. Super and yield nodes are an example of that. This forces us to check if node.loc responds to #keyword in a few places in rubocop proper and we can make it easier if we expose a method, here I have called it #selector, to all method dispatch nodes and work with it.
gsamokovarov
force-pushed
the
selector-for-yield-and-super
branch
from
670df28 to
60fc80e
Compare
|
Thanks @bbatsov and @gsamokovarov Released as v1.29.0 👍 |
|
Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you need to manipulate the call-site of a method dispatch, you have to use
node.loc.selectorfor regular methods andnode.loc.keywordfor syntax nodes that behave like method invocations. Super and yield nodes are nodes are examples.This forces us to check if
node.locresponds to#keywordin a few places in rubocop proper and we can make it easier if we expose a single method called#selector(the name is up for debate) and use it for method dispatch nodes.As an example, see HashSyntaxShorthand where I had to define a struct to hide away the selector detection.