Add character_literal? to StrNode
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `character_literal?` to `StrNode`.
`...begin.is?('?')` used in rubocop/rubocop#11095
and `Style/CharacterLiteral` can be rewritten by `node.character_literal?`.
8 tasks
|
Good stuff, thank @koic |
|
Thank you @marcandre! |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Oct 21, 2022
Follow up #11095 (comment) and rubocop/rubocop-ast#242. The API was introduced in rubocop-ast 1.23.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
character_literal?toStrNode....begin.is?('?')used in rubocop/rubocop#11095 andStyle/CharacterLiteralcan be rewritten bynode.character_literal?.