Invalidate Comunica caches after update queries

Closes LDflex/LDflex-Comunica#10
rubensworks · Feb 22, 2019 · b95888d · b95888d
1 parent a892996
commit b95888d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/ComunicaUpdateEngine.js b/src/ComunicaUpdateEngine.js
@@ -33,6 +33,9 @@ export default class ComunicaUpdateEngine extends ComunicaEngine {
         if (!response.ok)
           throw new Error(`Update query failed (${response.status}): ${response.statusText}`);
 
+        // Invalidate Comunica's internal caches, as they may have changed because of the update
+        await this._engine.invalidateHttpCache(document);
+
         // Mock Comunica's response for bindings as a Immutable.js object.
         return { value: { size: 1, values: () => ({ next: () => ({ value: { ok: true } }) }) } };
       }

diff --git a/test/ComunicaUpdateEngine-test.js b/test/ComunicaUpdateEngine-test.js
@@ -37,6 +37,12 @@ describe('a ComunicaUpdateEngine instance', () => {
       expect(args[1]).toHaveProperty('body');
       expect(args[1].body).toEqual('INSERT DATA { <> <> <> }');
     });
+
+    it('invalidates the document cache', () => {
+      expect(engine._engine.invalidateHttpCache).toHaveBeenCalledTimes(1);
+      const args = engine._engine.invalidateHttpCache.mock.calls[0];
+      expect(args[0]).toEqual('https://example.org/');
+    });
   });
 
   describe('Inserting an invalid query', () => {

diff --git a/test/__mocks__/ldflex-comunica.js b/test/__mocks__/ldflex-comunica.js
@@ -1,6 +1,9 @@
 export default class ComunicaEngineMock {
   constructor(subject, source) {
     this._source = source;
+    this._engine = {
+      invalidateHttpCache: jest.fn(() => Promise.resolve(true)),
+    };
   }
 
   getDocument() {