Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider SpanSizeLookup #53

Closed
wants to merge 1 commit into from
Closed

Conversation

ILAgent
Copy link

@ILAgent ILAgent commented Nov 2, 2018

fix #52

@rubensousa
Copy link
Owner

rubensousa commented Nov 4, 2018

Closing since we had to change the logic to search for the start/end views. We can't use findFirstVisibleItem position since it's not reliable when there's padding. The new logic covers the scenario you mentioned in your issue.

@rubensousa rubensousa closed this Nov 4, 2018
@ILAgent
Copy link
Author

ILAgent commented Nov 5, 2018

When are you going to implement that changed logic ? This solution could be as a workaround for a while.
Could you explain please the problem with padding ?
Thank you.

@rubensousa
Copy link
Owner

rubensousa commented Nov 5, 2018

I already did. Just need some time now to continue testing and prepare the release. I can only continue on the weekend though.

The main problem was identified by jt-gilkeson in #49. Basically, when a recyclerview has padding, findFirstVisibleItemPosition and findFirstCompletelyVisiblePosition don't work as expected and return RecyclerView.NO_POSITION. This breaks snapping and needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants