Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump 2.5.9 #6114

Merged
merged 22 commits into from
Jun 30, 2023
Merged

Version bump 2.5.9 #6114

merged 22 commits into from
Jun 30, 2023

Conversation

retailcoder
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@Vogel612
Copy link
Member

Last time I did that, I remember there being more version strings to adjust... Is that really all of them?

@retailcoder
Copy link
Member Author

retailcoder commented Jun 16, 2023

I just followed the version bump wiki, works on my machine! 🫣

The meta-project/solution really does simplify this that much, I think.

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@BZngr
Copy link
Contributor

BZngr commented Jun 21, 2023

In Discord you mentioned removing the version swapping script added to the development folder. I see that the script is still included in the PR. Just commenting in the event you still intended to remove it.

@retailcoder
Copy link
Member Author

In Discord you mentioned removing the version swapping script added to the development folder. I see that the script is still included in the PR. Just commenting in the event you still intended to remove it.

Thanks for the reminder, I would have forgotten!

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #6114 (fb5f08f) into next (1f1b1a3) will not change coverage.
The diff coverage is n/a.

❗ Current head fb5f08f differs from pull request most recent head a0d0311. Consider uploading reports for the commit a0d0311 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #6114   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files           4        4           
  Lines         413      413           
  Branches       28       28           
=======================================
  Hits          403      403           
  Misses          6        6           
  Partials        4        4           

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@rubberduck-vba-releasebot
Copy link
Member

@retailcoder retailcoder merged commit d03b512 into rubberduck-vba:next Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a user-agent header for VersionCheck requests
5 participants