Merge pull request #6029 from GmausDev/issue5723

Issue #5723
rubberduck-vba · Oct 26, 2022 · 9716496 · 9716496
2 parents 5243300 + 78e9382
commit 9716496
Show file tree

Hide file tree

Showing 13 changed files with 178 additions and 180 deletions.
diff --git a/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs b/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs
@@ -4,8 +4,9 @@ public enum CodeInspectionType
     {
         RubberduckOpportunities,
         LanguageOpportunities,
-        MaintainabilityAndReadabilityIssues,
+        NamingAndConventionsIssues,
         CodeQualityIssues,
         Performance,
+        Uncategorized,
     }
 }
diff --git a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs
diff --git a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings
@@ -6,7 +6,7 @@
       <Value Profile="(Default)">&lt;?xml version="1.0" encoding="utf-16"?&gt;
 &lt;CodeInspectionSettings xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"&gt;
   &lt;CodeInspections&gt;
-    &lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="StopKeywordInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="UnhandledOnErrorResumeNextInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
@@ -18,52 +18,52 @@
     &lt;CodeInspection Name="AttributeOutOfSyncInspection" Severity="Warning" InspectionType="RubberduckOpportunities" /&gt;
     &lt;CodeInspection Name="MissingAnnotationArgumentInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="RedundantOptionInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="OptionExplicitInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ProcedureCanBeWrittenAsFunctionInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ApplicationWorksheetFunctionInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="AssignedByValParameterInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="IntegerDataTypeInspection" Severity="Hint" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ShadowedDeclarationInspection" Severity="DoNotShow" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ConstantNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
-    &lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
-    &lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
+    &lt;CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="ImplicitActiveSheetReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ImplicitActiveWorkbookReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ImplicitDefaultMemberAssignmentInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ImplicitPublicMemberInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ImplicitVariantReturnTypeInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
-    &lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="NonReturningFunctionInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ObsoleteGlobalInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="ParameterNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="SelfAssignedDeclarationInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="UnassignedVariableUsageInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="UndeclaredVariableInspection" Severity="Error" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="VariableNotAssignedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="VariableNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="VariableTypeNotDeclaredInspection" Severity="Warning" InspectionType="LanguageOpportunities" /&gt;
@@ -72,7 +72,7 @@
     &lt;CodeInspection Name="StepIsNotSpecifiedInspection" Severity="DoNotShow" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="StepOneIsRedundantInspection" Severity="Hint" InspectionType="LanguageOpportunities" /&gt;
     &lt;CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /&gt;
-    &lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /&gt;
+    &lt;CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /&gt;
     &lt;CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning" InspectionType="CodeQualityIssues" /&gt;
     &lt;CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error" InspectionType="RubberduckOpportunities" /&gt;
     &lt;CodeInspection Name="ModuleWithoutFolderInspection" Severity="Suggestion" InspectionType="RubberduckOpportunities" /&gt;

diff --git a/Rubberduck.CodeAnalysis/app.config b/Rubberduck.CodeAnalysis/app.config
@@ -22,7 +22,7 @@
             xmlns:xsd="http://www.w3.org/2001/XMLSchema">
             <CodeInspections>
               <CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="StopKeywordInspection" Severity="Suggestion"
@@ -46,16 +46,16 @@
               <CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="MultilineParameterInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
-              <CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" />
+              <CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="RedundantOptionInspection" Severity="Hint"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="OptionExplicitInspection" Severity="Error"
@@ -67,7 +67,7 @@
               <CodeInspection Name="AssignedByValParameterInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="EmptyModuleInspection" Severity="Hint"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="IntegerDataTypeInspection" Severity="Hint"
@@ -77,27 +77,27 @@
               <CodeInspection Name="ConstantNotUsedInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyElseBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyIfBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="HungarianNotationInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="ImplicitActiveSheetReferenceInspection"
                 Severity="Warning" InspectionType="LanguageOpportunities" />
               <CodeInspection Name="ImplicitActiveWorkbookReferenceInspection"
@@ -111,7 +111,7 @@
               <CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="NonReturningFunctionInspection" Severity="Error"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error"
@@ -121,7 +121,7 @@
               <CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="ParameterNotUsedInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning"
@@ -135,7 +135,7 @@
               <CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="VariableNotAssignedInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="VariableNotUsedInspection" Severity="Warning"
@@ -153,7 +153,7 @@
               <CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion"
                 InspectionType="LanguageOpportunities" />
               <CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning"
-                InspectionType="MaintainabilityAndReadabilityIssues" />
+                InspectionType="NamingAndConventionsIssues" />
               <CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning"
                 InspectionType="CodeQualityIssues" />
               <CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error"