Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to work with scala.rx 0.3.2 #5

Merged
merged 5 commits into from
Nov 11, 2016
Merged

Conversation

drhumlen
Copy link
Contributor

@drhumlen drhumlen commented Nov 8, 2016

No description provided.

@drhumlen
Copy link
Contributor Author

drhumlen commented Nov 8, 2016

I think there's been some changes to ScalaJs. It seems that you now get the error: Error: Cannot find module 'jsdom' when you have requiresDOM := true in your build.sbt, which is why the build is breaking...

I fixed it on my machine by just doing a npm install jsdom from the project root folder, but I'm not sure if it's the recommended way to do it. If it is, I guess we could add npm install jsdom as one of the steps in .travis.yml

@drhumlen
Copy link
Contributor Author

drhumlen commented Nov 8, 2016

Found this: scala-js/scala-js#2642

It seems npm install jsdom is the way to do it. Added it to travis.yml now. Let's hope it works 🙏

@rtimush
Copy link
Owner

rtimush commented Nov 11, 2016

Thank you, this was a huge work!

@rtimush rtimush merged commit bf3ad08 into rtimush:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants