Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for the fact that element_blank() elements are length 0, but should be considered defined #83

Merged
merged 29 commits into from
Feb 2, 2021
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
820d464
Close #82: Account for the fact that element_blank() elements are len…
cpsievert Feb 1, 2021
4fa68d6
Add a visual test
cpsievert Feb 1, 2021
3959a4f
Add link to PR
cpsievert Feb 1, 2021
f0846eb
Fix for brew cask
cpsievert Feb 1, 2021
b90a048
Appears vdiffr figs aren't being fetched
cpsievert Feb 1, 2021
2d5a800
Update new vdiffr baselines
cpsievert Feb 1, 2021
0a3c1b3
Do better at managing state in tests; fix for sf warning
cpsievert Feb 1, 2021
2c12fc3
Update news
cpsievert Feb 1, 2021
170f690
Temporarily disable shinytest
cpsievert Feb 1, 2021
8d638ab
Try pulling
cpsievert Feb 1, 2021
26218ec
Check if vdiffr tests are actually running
cpsievert Feb 1, 2021
c09c05d
Try running shinytest tests in background process; update testing dep…
cpsievert Feb 1, 2021
5fcc008
Close #79: Don't call shiny::getCurrentOutputInfo() unless shiny is a…
cpsievert Feb 1, 2021
652a693
List svg files
cpsievert Feb 1, 2021
3a20cf3
Temporarily disable R CMD check and just run tests
cpsievert Feb 1, 2021
bd3d368
Install pkg
cpsievert Feb 1, 2021
db69dbb
Propogate devtools::test() failures/errors to top-level error
cpsievert Feb 1, 2021
221803a
whoops
cpsievert Feb 1, 2021
15cf057
upload entire dir
cpsievert Feb 1, 2021
2434654
revert change to hist() baseline
cpsievert Feb 1, 2021
9a2160c
try just committing the tests
cpsievert Feb 1, 2021
b3333dd
fix test
cpsievert Feb 2, 2021
0bd0fee
update renderPlot() baselines on mac
cpsievert Feb 2, 2021
19d2db4
update win baseline
cpsievert Feb 2, 2021
03eeaeb
fix test
cpsievert Feb 2, 2021
3eb2b82
don't ignore -current folders
cpsievert Feb 2, 2021
5b7baf8
cleanup
cpsievert Feb 2, 2021
33fad1f
Add bslib to suggests
cpsievert Feb 2, 2021
0e6eaec
Also run R CMD check (but without tests)
cpsievert Feb 2, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Propogate devtools::test() failures/errors to top-level error
  • Loading branch information
cpsievert committed Feb 1, 2021
commit db69dbb52eb4c77ba1ae85546b7936fb1a12d78a
19 changes: 11 additions & 8 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,20 +150,23 @@ jobs:
Rscript
-e "cat('::set-output name=name::gha-', '${{ steps.failed_branch.outputs.name }}', '-', '${{ matrix.config.r }}', '-', '${{ runner.os }}', sep = '')"

#- name: Check
# run: rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check")
# shell: Rscript {0}

- name: Install devtools
run: install.packages("devtools")
shell: Rscript {0}

- name: Instal pkg
run: devtools::install()
shell: Rscript {0}
- name: Run Tests
run: devtools::test()
run: >
devtools::install()
res <- devtools::test()
df <- as.data.frame(res)
if (sum(df$failed) > 0 || any(df$error)) stop("GHA CI tests failed")
shell: Rscript {0}

# For some odd reason it seems the vdiffr tests were being skipped
#- name: Check
# run: rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check")
# shell: Rscript {0}

- name: Upload check results
if: failure()
uses: actions/upload-artifact@master
Expand Down