Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables removed axis text #82

Closed
nstrayer opened this issue Feb 1, 2021 · 0 comments · Fixed by #83
Closed

Re-enables removed axis text #82

nstrayer opened this issue Feb 1, 2021 · 0 comments · Fixed by #83
Assignees

Comments

@nstrayer
Copy link

nstrayer commented Feb 1, 2021

Describe the problem

If you build a custom ggplot2::theme() that removes axis text, thematic will re-enable the text

library(ggplot2)
library(thematic)
thematic_on()
ggplot() +
  scale_y_continuous(limits = c(0,4)) +
  theme(axis.text.y = element_blank())

image

As compared to the following without thematic running:

image

Session Info


sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 4.0.2 (2020-06-22)
#>  os       macOS Catalina 10.15.7      
#>  system   x86_64, darwin17.0          
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       America/Detroit             
#>  date     2021-02-01                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source                            
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 4.0.2)                    
#>  backports     1.2.1      2020-12-09 [1] CRAN (R 4.0.2)                    
#>  bslib         0.2.4.9000 2021-01-28 [1] local                             
#>  cli           2.2.0.9000 2021-01-15 [1] Github (r-lib/cli@d2f1506)        
#>  colorspace    2.0-0      2020-11-11 [1] CRAN (R 4.0.2)                    
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 4.0.2)                    
#>  DBI           1.1.1      2021-01-15 [1] CRAN (R 4.0.2)                    
#>  digest        0.6.27     2020-10-24 [1] CRAN (R 4.0.2)                    
#>  dplyr         1.0.3      2021-01-15 [1] CRAN (R 4.0.0)                    
#>  ellipsis      0.3.1      2020-05-15 [1] CRAN (R 4.0.2)                    
#>  evaluate      0.14       2019-05-28 [1] CRAN (R 4.0.1)                    
#>  farver        2.0.3      2020-01-16 [1] CRAN (R 4.0.2)                    
#>  fastmap       1.0.1.9001 2021-01-15 [1] Github (r-lib/fastmap@e23f9c2)    
#>  fs            1.5.0      2020-07-31 [1] CRAN (R 4.0.2)                    
#>  generics      0.1.0      2020-10-31 [1] CRAN (R 4.0.2)                    
#>  ggplot2     * 3.3.3      2020-12-30 [1] CRAN (R 4.0.2)                    
#>  glue          1.4.2      2020-08-27 [1] CRAN (R 4.0.2)                    
#>  gtable        0.3.0      2019-03-25 [1] CRAN (R 4.0.2)                    
#>  highr         0.8        2019-03-20 [1] CRAN (R 4.0.2)                    
#>  htmltools     0.5.1      2021-01-12 [1] CRAN (R 4.0.2)                    
#>  httpuv        1.5.5      2021-01-13 [1] CRAN (R 4.0.2)                    
#>  jquerylib     0.1.3      2020-12-17 [1] CRAN (R 4.0.2)                    
#>  jsonlite      1.7.2      2020-12-09 [1] CRAN (R 4.0.2)                    
#>  knitr         1.30       2020-09-22 [1] CRAN (R 4.0.2)                    
#>  labeling      0.4.2      2020-10-20 [1] CRAN (R 4.0.2)                    
#>  later         1.1.0.9000 2021-01-15 [1] Github (r-lib/later@eb2c8ad)      
#>  lattice       0.20-41    2020-04-02 [1] CRAN (R 4.0.2)                    
#>  lifecycle     0.2.0      2020-03-06 [1] CRAN (R 4.0.2)                    
#>  magrittr      2.0.1      2020-11-17 [1] CRAN (R 4.0.2)                    
#>  mime          0.9        2020-02-04 [1] CRAN (R 4.0.2)                    
#>  munsell       0.5.0      2018-06-12 [1] CRAN (R 4.0.2)                    
#>  pillar        1.4.7      2020-11-20 [1] CRAN (R 4.0.2)                    
#>  pkgconfig     2.0.3      2019-09-22 [1] CRAN (R 4.0.2)                    
#>  promises      1.1.1.9001 2021-01-15 [1] Github (rstudio/promises@55ca04f) 
#>  purrr         0.3.4      2020-04-17 [1] CRAN (R 4.0.2)                    
#>  R6            2.5.0      2020-10-28 [1] CRAN (R 4.0.2)                    
#>  ragg          0.4.1      2021-01-11 [1] CRAN (R 4.0.2)                    
#>  Rcpp          1.0.6      2021-01-15 [1] CRAN (R 4.0.0)                    
#>  reprex        1.0.0      2021-01-27 [1] CRAN (R 4.0.2)                    
#>  rlang         0.4.10     2020-12-30 [1] CRAN (R 4.0.2)                    
#>  rmarkdown     2.6.6      2021-01-22 [1] Github (rstudio/rmarkdown@f573088)
#>  rstudioapi    0.13       2020-11-12 [1] CRAN (R 4.0.2)                    
#>  sass          0.3.0      2021-01-13 [1] CRAN (R 4.0.2)                    
#>  scales        1.1.1      2020-05-11 [1] CRAN (R 4.0.2)                    
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 4.0.2)                    
#>  shiny         1.6.0      2021-01-15 [1] Github (rstudio/shiny@5ddff1b)    
#>  stringi       1.5.3      2020-09-09 [1] CRAN (R 4.0.2)                    
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 4.0.2)                    
#>  styler        1.3.2      2020-02-23 [1] CRAN (R 4.0.2)                    
#>  systemfonts   0.3.2      2020-09-29 [1] CRAN (R 4.0.2)                    
#>  textshaping   0.2.1      2020-11-13 [1] CRAN (R 4.0.2)                    
#>  thematic    * 0.1.1      2021-01-15 [1] Github (rstudio/thematic@a92e59b) 
#>  tibble        3.0.5      2021-01-15 [1] CRAN (R 4.0.0)                    
#>  tidyselect    1.1.0      2020-05-11 [1] CRAN (R 4.0.2)                    
#>  vctrs         0.3.6      2020-12-17 [1] CRAN (R 4.0.2)                    
#>  withr         2.3.0      2020-09-22 [1] CRAN (R 4.0.2)                    
#>  xfun          0.20       2021-01-06 [1] CRAN (R 4.0.2)                    
#>  xtable        1.8-4      2019-04-21 [1] CRAN (R 4.0.2)                    
#>  yaml          2.2.1      2020-02-01 [1] CRAN (R 4.0.2)                    
#> 
#> [1] /Library/Frameworks/R.framework/Versions/4.0/Resources/library
@nstrayer nstrayer self-assigned this Feb 1, 2021
cpsievert added a commit that referenced this issue Feb 1, 2021
cpsievert added a commit that referenced this issue Feb 2, 2021
…should be considered defined (#83)

* Close #82: Account for the fact that element_blank() elements are length 0, but should be considered defined

* Add a visual test

* Add link to PR

* Fix for brew cask

* Appears vdiffr figs aren't being fetched

* Update new vdiffr baselines

* Do better at managing state in tests; fix for sf warning

* Update news

* Temporarily disable shinytest

* Try pulling

* Check if vdiffr tests are actually running

* Try running shinytest tests in background process; update testing dependencies

* Close #79: Don't call shiny::getCurrentOutputInfo() unless shiny is already loaded

* List svg files

* Temporarily disable R CMD check and just run tests

* Install pkg

* Propogate devtools::test() failures/errors to top-level error

* whoops

* upload entire dir

* revert change to hist() baseline

* try just committing the tests

* fix test

* update renderPlot() baselines on mac

* update win baseline

* fix test

* don't ignore -current folders

* cleanup

* Add bslib to suggests

* Also run R CMD check (but without tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant