More officially support the ggiraph::dsvg graphics device (#112)

rstudio · Oct 20, 2021 · 98b5102 · 98b5102
1 parent 9858628
commit 98b5102
Show file tree

Hide file tree

Showing 107 changed files with 8,445 additions and 8,439 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: thematic
 Title: Unified and Automatic 'Theming' of 'ggplot2', 'lattice', and 'base' R Graphics
-Version: 0.1.2.1
+Version: 0.1.2.9000
 Authors@R: c(
   person("Carson", "Sievert", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0002-4958-2844")),
   person("Barret", "Schloerke", email = "[email protected]", role = "aut", comment = c(ORCID = "0000-0001-9986-114X")),
@@ -40,6 +40,7 @@ Suggests:
     bslib,
     testthat,
     gganimate,
+    ggiraph,
     vdiffr (>= 1.0.0),
     svglite,
     jsonlite,

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# thematic 0.1.2.9000
+
+* Closed #111: `{thematic}` no longer throws an error when used with `ggiraph::dsvg()`. (#112)
+
 # thematic 0.1.2.1
 
 Patch release for vdiffr 1.0

diff --git a/R/hooks.R b/R/hooks.R
@@ -246,6 +246,7 @@ get_device_function <- function(name = infer_device()) {
     agg_jpeg = ragg::agg_jpeg,
     Cairo = Cairo::Cairo,
     devSVG = svglite::svglite,
+    dsvg_device = ggiraph::dsvg,
     # TODO: support cairoDevices? tikz?
     stop(
       "thematic doesn't (yet) support the '", name, "' graphics device. ",

diff --git a/tests/testthat/_snaps/base/barplot-accent.svg b/tests/testthat/_snaps/base/barplot-accent.svg
diff --git a/tests/testthat/_snaps/base/barplot.svg b/tests/testthat/_snaps/base/barplot.svg
diff --git a/tests/testthat/_snaps/base/hist.svg b/tests/testthat/_snaps/base/hist.svg
diff --git a/tests/testthat/_snaps/base/lines-accent.svg b/tests/testthat/_snaps/base/lines-accent.svg
diff --git a/tests/testthat/_snaps/base/lines-cols.svg b/tests/testthat/_snaps/base/lines-cols.svg
diff --git a/tests/testthat/_snaps/base/lines.svg b/tests/testthat/_snaps/base/lines.svg
diff --git a/tests/testthat/_snaps/base/pairs.svg b/tests/testthat/_snaps/base/pairs.svg
diff --git a/tests/testthat/_snaps/base/pies.svg b/tests/testthat/_snaps/base/pies.svg
diff --git a/tests/testthat/_snaps/base/qq.svg b/tests/testthat/_snaps/base/qq.svg
diff --git a/tests/testthat/_snaps/base/scatter-cols.svg b/tests/testthat/_snaps/base/scatter-cols.svg
diff --git a/tests/testthat/_snaps/base/scatter.svg b/tests/testthat/_snaps/base/scatter.svg
diff --git a/tests/testthat/_snaps/base/smooth-accent.svg b/tests/testthat/_snaps/base/smooth-accent.svg
diff --git a/tests/testthat/_snaps/base/stripchart-cols.svg b/tests/testthat/_snaps/base/stripchart-cols.svg
diff --git a/tests/testthat/_snaps/base/stripchart.svg b/tests/testthat/_snaps/base/stripchart.svg
diff --git a/tests/testthat/_snaps/ggplot/geomabline.svg b/tests/testthat/_snaps/ggplot/geomabline.svg
diff --git a/tests/testthat/_snaps/ggplot/geombar.svg b/tests/testthat/_snaps/ggplot/geombar.svg
diff --git a/tests/testthat/_snaps/ggplot/geombin2d.svg b/tests/testthat/_snaps/ggplot/geombin2d.svg
diff --git a/tests/testthat/_snaps/ggplot/geombox.svg b/tests/testthat/_snaps/ggplot/geombox.svg
diff --git a/tests/testthat/_snaps/ggplot/geomcount.svg b/tests/testthat/_snaps/ggplot/geomcount.svg
diff --git a/tests/testthat/_snaps/ggplot/geomcurve.svg b/tests/testthat/_snaps/ggplot/geomcurve.svg
diff --git a/tests/testthat/_snaps/ggplot/geomdensity.svg b/tests/testthat/_snaps/ggplot/geomdensity.svg
diff --git a/tests/testthat/_snaps/ggplot/geomdensitycolor.svg b/tests/testthat/_snaps/ggplot/geomdensitycolor.svg
diff --git a/tests/testthat/_snaps/ggplot/geomdotplot.svg b/tests/testthat/_snaps/ggplot/geomdotplot.svg
diff --git a/tests/testthat/_snaps/ggplot/geomerror.svg b/tests/testthat/_snaps/ggplot/geomerror.svg
diff --git a/tests/testthat/_snaps/ggplot/geomerrorbar.svg b/tests/testthat/_snaps/ggplot/geomerrorbar.svg
diff --git a/tests/testthat/_snaps/ggplot/geomhistogram.svg b/tests/testthat/_snaps/ggplot/geomhistogram.svg
diff --git a/tests/testthat/_snaps/ggplot/geomjitter.svg b/tests/testthat/_snaps/ggplot/geomjitter.svg
diff --git a/tests/testthat/_snaps/ggplot/geomlabel.svg b/tests/testthat/_snaps/ggplot/geomlabel.svg
diff --git a/tests/testthat/_snaps/ggplot/geomline.svg b/tests/testthat/_snaps/ggplot/geomline.svg
diff --git a/tests/testthat/_snaps/ggplot/geomline2.svg b/tests/testthat/_snaps/ggplot/geomline2.svg
diff --git a/tests/testthat/_snaps/ggplot/geompoint.svg b/tests/testthat/_snaps/ggplot/geompoint.svg
diff --git a/tests/testthat/_snaps/ggplot/geompoint2.svg b/tests/testthat/_snaps/ggplot/geompoint2.svg
diff --git a/tests/testthat/_snaps/ggplot/geompointcolor.svg b/tests/testthat/_snaps/ggplot/geompointcolor.svg
diff --git a/tests/testthat/_snaps/ggplot/geompolygon.svg b/tests/testthat/_snaps/ggplot/geompolygon.svg
diff --git a/tests/testthat/_snaps/ggplot/geompolygon2.svg b/tests/testthat/_snaps/ggplot/geompolygon2.svg
diff --git a/tests/testthat/_snaps/ggplot/geomribbon.svg b/tests/testthat/_snaps/ggplot/geomribbon.svg
diff --git a/tests/testthat/_snaps/ggplot/geomrug.svg b/tests/testthat/_snaps/ggplot/geomrug.svg
diff --git a/tests/testthat/_snaps/ggplot/geomrug2.svg b/tests/testthat/_snaps/ggplot/geomrug2.svg
diff --git a/tests/testthat/_snaps/ggplot/geomsf.svg b/tests/testthat/_snaps/ggplot/geomsf.svg
diff --git a/tests/testthat/_snaps/ggplot/geomsmooth.svg b/tests/testthat/_snaps/ggplot/geomsmooth.svg
diff --git a/tests/testthat/_snaps/ggplot/geomsmooth2.svg b/tests/testthat/_snaps/ggplot/geomsmooth2.svg
diff --git a/tests/testthat/_snaps/ggplot/geomspoke.svg b/tests/testthat/_snaps/ggplot/geomspoke.svg
diff --git a/tests/testthat/_snaps/ggplot/geomtext.svg b/tests/testthat/_snaps/ggplot/geomtext.svg
diff --git a/tests/testthat/_snaps/ggplot/geomtile.svg b/tests/testthat/_snaps/ggplot/geomtile.svg
diff --git a/tests/testthat/_snaps/ggplot/geomviolin.svg b/tests/testthat/_snaps/ggplot/geomviolin.svg
diff --git a/tests/testthat/_snaps/ggplot/grid-arrange.svg b/tests/testthat/_snaps/ggplot/grid-arrange.svg
diff --git a/tests/testthat/_snaps/ggplot/no-y-text.svg b/tests/testthat/_snaps/ggplot/no-y-text.svg
diff --git a/tests/testthat/_snaps/ggplot/patchwork.svg b/tests/testthat/_snaps/ggplot/patchwork.svg
diff --git a/tests/testthat/_snaps/ggplot/qualitative-color.svg b/tests/testthat/_snaps/ggplot/qualitative-color.svg
diff --git a/tests/testthat/_snaps/ggplot/qualitative-fill.svg b/tests/testthat/_snaps/ggplot/qualitative-fill.svg
diff --git a/tests/testthat/_snaps/ggplot/sequential-color.svg b/tests/testthat/_snaps/ggplot/sequential-color.svg
diff --git a/tests/testthat/_snaps/ggplot/sequential-fill.svg b/tests/testthat/_snaps/ggplot/sequential-fill.svg
diff --git a/tests/testthat/_snaps/ggthemes/axis-interitance-distant.svg b/tests/testthat/_snaps/ggthemes/axis-interitance-distant.svg
diff --git a/tests/testthat/_snaps/ggthemes/axis-interitance-distant2.svg b/tests/testthat/_snaps/ggthemes/axis-interitance-distant2.svg
diff --git a/tests/testthat/_snaps/ggthemes/axis-interitance.svg b/tests/testthat/_snaps/ggthemes/axis-interitance.svg
diff --git a/tests/testthat/_snaps/ggthemes/base.svg b/tests/testthat/_snaps/ggthemes/base.svg
diff --git a/tests/testthat/_snaps/ggthemes/bw.svg b/tests/testthat/_snaps/ggthemes/bw.svg
diff --git a/tests/testthat/_snaps/ggthemes/calc.svg b/tests/testthat/_snaps/ggthemes/calc.svg
diff --git a/tests/testthat/_snaps/ggthemes/classic.svg b/tests/testthat/_snaps/ggthemes/classic.svg
diff --git a/tests/testthat/_snaps/ggthemes/clean.svg b/tests/testthat/_snaps/ggthemes/clean.svg
diff --git a/tests/testthat/_snaps/ggthemes/dark.svg b/tests/testthat/_snaps/ggthemes/dark.svg
diff --git a/tests/testthat/_snaps/ggthemes/economist-white.svg b/tests/testthat/_snaps/ggthemes/economist-white.svg
diff --git a/tests/testthat/_snaps/ggthemes/economist.svg b/tests/testthat/_snaps/ggthemes/economist.svg
diff --git a/tests/testthat/_snaps/ggthemes/excel-new.svg b/tests/testthat/_snaps/ggthemes/excel-new.svg
diff --git a/tests/testthat/_snaps/ggthemes/excel.svg b/tests/testthat/_snaps/ggthemes/excel.svg
diff --git a/tests/testthat/_snaps/ggthemes/few.svg b/tests/testthat/_snaps/ggthemes/few.svg
diff --git a/tests/testthat/_snaps/ggthemes/fivethirtyeight.svg b/tests/testthat/_snaps/ggthemes/fivethirtyeight.svg
diff --git a/tests/testthat/_snaps/ggthemes/foundation.svg b/tests/testthat/_snaps/ggthemes/foundation.svg
diff --git a/tests/testthat/_snaps/ggthemes/gdocs.svg b/tests/testthat/_snaps/ggthemes/gdocs.svg
diff --git a/tests/testthat/_snaps/ggthemes/ggtheme-minimal.svg b/tests/testthat/_snaps/ggthemes/ggtheme-minimal.svg
diff --git a/tests/testthat/_snaps/ggthemes/ggtheme-void.svg b/tests/testthat/_snaps/ggthemes/ggtheme-void.svg
diff --git a/tests/testthat/_snaps/ggthemes/hc.svg b/tests/testthat/_snaps/ggthemes/hc.svg
diff --git a/tests/testthat/_snaps/ggthemes/igray.svg b/tests/testthat/_snaps/ggthemes/igray.svg
diff --git a/tests/testthat/_snaps/ggthemes/light.svg b/tests/testthat/_snaps/ggthemes/light.svg
diff --git a/tests/testthat/_snaps/ggthemes/linedraw.svg b/tests/testthat/_snaps/ggthemes/linedraw.svg
diff --git a/tests/testthat/_snaps/ggthemes/map.svg b/tests/testthat/_snaps/ggthemes/map.svg
diff --git a/tests/testthat/_snaps/ggthemes/minimal.svg b/tests/testthat/_snaps/ggthemes/minimal.svg
diff --git a/tests/testthat/_snaps/ggthemes/pander.svg b/tests/testthat/_snaps/ggthemes/pander.svg
diff --git a/tests/testthat/_snaps/ggthemes/par.svg b/tests/testthat/_snaps/ggthemes/par.svg
diff --git a/tests/testthat/_snaps/ggthemes/purple-strip.svg b/tests/testthat/_snaps/ggthemes/purple-strip.svg
diff --git a/tests/testthat/_snaps/ggthemes/solarized-2.svg b/tests/testthat/_snaps/ggthemes/solarized-2.svg
diff --git a/tests/testthat/_snaps/ggthemes/solarized.svg b/tests/testthat/_snaps/ggthemes/solarized.svg
diff --git a/tests/testthat/_snaps/ggthemes/stata.svg b/tests/testthat/_snaps/ggthemes/stata.svg
diff --git a/tests/testthat/_snaps/ggthemes/tufte.svg b/tests/testthat/_snaps/ggthemes/tufte.svg
diff --git a/tests/testthat/_snaps/ggthemes/void.svg b/tests/testthat/_snaps/ggthemes/void.svg
diff --git a/tests/testthat/_snaps/ggthemes/wsj.svg b/tests/testthat/_snaps/ggthemes/wsj.svg
diff --git a/tests/testthat/_snaps/lattice/bwplot.svg b/tests/testthat/_snaps/lattice/bwplot.svg
diff --git a/tests/testthat/_snaps/lattice/cleveland.svg b/tests/testthat/_snaps/lattice/cleveland.svg
diff --git a/tests/testthat/_snaps/lattice/density-plot.svg b/tests/testthat/_snaps/lattice/density-plot.svg
diff --git a/tests/testthat/_snaps/lattice/dot-plot.svg b/tests/testthat/_snaps/lattice/dot-plot.svg
diff --git a/tests/testthat/_snaps/lattice/interaction-plot.svg b/tests/testthat/_snaps/lattice/interaction-plot.svg
diff --git a/tests/testthat/_snaps/lattice/level-plot.svg b/tests/testthat/_snaps/lattice/level-plot.svg
diff --git a/tests/testthat/_snaps/lattice/settings.svg b/tests/testthat/_snaps/lattice/settings.svg
diff --git a/tests/testthat/_snaps/lattice/settings2.svg b/tests/testthat/_snaps/lattice/settings2.svg
diff --git a/tests/testthat/_snaps/lattice/xyplot.svg b/tests/testthat/_snaps/lattice/xyplot.svg
diff --git a/tests/testthat/_snaps/sequential-gradient/accent-bg.svg b/tests/testthat/_snaps/sequential-gradient/accent-bg.svg
diff --git a/tests/testthat/_snaps/sequential-gradient/fg-accent.svg b/tests/testthat/_snaps/sequential-gradient/fg-accent.svg
diff --git a/tests/testthat/_snaps/sequential-gradient/half-half-reversed.svg b/tests/testthat/_snaps/sequential-gradient/half-half-reversed.svg
diff --git a/tests/testthat/_snaps/sequential-gradient/half-half.svg b/tests/testthat/_snaps/sequential-gradient/half-half.svg
diff --git a/tests/testthat/_snaps/state/green.svg b/tests/testthat/_snaps/state/green.svg
diff --git a/tests/testthat/_snaps/state/purple.svg b/tests/testthat/_snaps/state/purple.svg
diff --git a/tests/testthat/_snaps/state/scatter-with-theme.svg b/tests/testthat/_snaps/state/scatter-with-theme.svg
diff --git a/tests/testthat/_snaps/state/white-green.svg b/tests/testthat/_snaps/state/white-green.svg
diff --git a/tests/testthat/_snaps/state/white-red.svg b/tests/testthat/_snaps/state/white-red.svg