Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inst/shiny -> inst/examples-shiny #4003

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Mar 21, 2024

Moves the new, non-legacy shiny examples from inst/shiny to inst/examples-shiny.

See prior discussions in #3907

@cpsievert
Copy link
Collaborator

I'm pretty sure @schloerke wants it to be inst/{package}

@gadenbuie
Copy link
Member Author

I'm pretty sure @schloerke wants it to be inst/{package}

Oh, from #3907 it sounded like a fixed inst/shiny was the recommendation and in #3917 Karan implemented it as inst/shiny-examples.

I feel pretty strongly that we should use a clear, unambiguous and likely unique directory name for the purpose of shiny::runExample() and that inst/examples-shiny fits that bill.

@cpsievert cpsievert merged commit d855468 into main Mar 21, 2024
12 checks passed
@cpsievert cpsievert deleted the chore/rename-examples-dir branch March 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants