Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing terra:: for has.RGB() #866

Closed
Rafnuss opened this issue Jul 9, 2023 · 1 comment · Fixed by #869
Closed

Missing terra:: for has.RGB() #866

Rafnuss opened this issue Jul 9, 2023 · 1 comment · Fixed by #869
Assignees
@gadenbuie

Comments

@Rafnuss
Copy link

Rafnuss commented Jul 9, 2023

leaflet/R/layers.R

Line 468 in 0f8e831

if (has.RGB(x)) {

should be

if (terra::has.RGB(x)) {

Or I could be wrong and I still don't really understand the use of ::
@audricvigier
Copy link

I'm currently having issues displaying a SpatRaster because of this, could terra:: be added in front of all has.RGB please? That would save a lot of time to people wondering what's happening the first time they encounter an error stating that has.RGB does not exist.

@gadenbuie gadenbuie self-assigned this Aug 1, 2023
gadenbuie added a commit that referenced this issue Aug 1, 2023
@gadenbuie
fix: Call terra::has.RGB() with namespace
0e2a7fc 
Fixes #866
@gadenbuie gadenbuie mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadenbuie gadenbuie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call terra::has.RGB() with namespace rstudio/leaflet
3 participants
@gadenbuie @Rafnuss @audricvigier